[aot] Fixed ti_get_last_error signature #7165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
PENGUINLIONG
added a commit
that referenced
this pull request
Jan 16, 2023
Issue: # ### Brief Summary Initially `ti_get_last_error` returns `TI_EROR_TRUNCATED` to hint the user that the message output is not complete (because the buffer size is insufficient), but this 'non-failing' error code has been removed in later commits. So at this point this API doesn't have a reliable way to know whether the error message is complete. This is considered problematic.
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: # ### Brief Summary Initially `ti_get_last_error` returns `TI_EROR_TRUNCATED` to hint the user that the message output is not complete (because the buffer size is insufficient), but this 'non-failing' error code has been removed in later commits. So at this point this API doesn't have a reliable way to know whether the error message is complete. This is considered problematic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
Initially
ti_get_last_errorreturnsTI_EROR_TRUNCATEDto hint the user that the message output is not complete (because the buffer size is insufficient), but this 'non-failing' error code has been removed in later commits. So at this point this API doesn't have a reliable way to know whether the error message is complete. This is considered problematic.